feat: add probe readiness devtools command#977
Open
piotr-iohk wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0dc074db7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of synonymdev/bitkit-nightly#17
This PR adds a debug-only
probeReadinessdevtools command so the mainnet Lightning probe E2E tests can inspect the wallet's routing readiness directly, instead of relying on a fixed stabilization delay.Description
LightningRepo.probeReadiness()returning aProbeReadinesssnapshot: node running, lifecycle, peers / connected peers, channels / ready / usable, outbound capacity sats, network graph node and channel counts, latest RGS sync timestamp, and sync health, plus a derivedreadyflag.DevToolsProvideras theprobeReadinesscommand (ADBcontent call), returning a serialized result.Debug/test-only (debug source set); no impact on release builds.
Preview
N/A — debug devtools command, no UI.
QA Notes
Manual Tests
adb shell content call --uri content://to.bitkit.devtools --method probeReadiness: returns JSON withready, peers, channels, and graph counts.ready=true,usableChannels>0,graphChannelCountin the tens of thousands.Automated Checks
probeReadiness()ready and not-ready paths inapp/src/test/.../LightningRepoTest.kt.Made with Cursor